[Test] Prevent false positive failures in test test_update_race_condition. #7302
Merged
gmarciani merged 2 commits intoaws:developfrom Mar 20, 2026
Merged
Conversation
gmarciani
added
3.x
skip-changelog-update
gmarciani
force-pushed
the
wip/mgiacomo/3150/test-update-race-conditions-0318-1
branch
4 times, most recently
from
1261020 to
f4425ad
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gmarciani
force-pushed
the
wip/mgiacomo/3150/test-update-race-conditions-0318-1
branch
5 times, most recently
from
85bf9da to
9dc3893
Compare
gmarciani
force-pushed
the
wip/mgiacomo/3150/test-update-race-conditions-0318-1
branch
from
9dc3893 to
6a40bbf
Compare
gmarciani
changed the title
match_regex_in_log so that the test test_update_race_condition is able to detect expected log lines and prevent false positive failures.test_update_race_condition.
gmarciani
force-pushed
the
wip/mgiacomo/3150/test-update-race-conditions-0318-1
branch
3 times, most recently
from
c5cc4b2 to
b3bd90b
Compare
hehe7318
reviewed
Mar 20, 2026
…ition`. In particular: 1. do not fail when the cluster update fails only because of the known race condition on login node. 2. when cluster fails the update, determine the cluster snapshot used by the assertions only after the head node completed the update recipe, so that the snapshot contains reliable data.
gmarciani
force-pushed
the
wip/mgiacomo/3150/test-update-race-conditions-0318-1
branch
from
b3bd90b to
563fca6
Compare
hehe7318
approved these changes
Mar 20, 2026
gmarciani
deleted the
wip/mgiacomo/3150/test-update-race-conditions-0318-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Prevent false positive failures in test
test_update_race_condition. In particular:Tests
SUCCEEDED
test_update_race_conditionson all OSs except for AL2 where there is a known issue about a logging file we need to fix in the productBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.